Repository navigation
feat: Generalize OFE over the type of step indices - #731
Open
markusdemedeiros wants to merge 3 commits into
Open
markusdemedeiros wants to merge 3 commits into
markusdemedeiros wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the first PR that generalizes existing Iris to handle arbitrary step indices. In it, I generalized OFE.lean, and fixed the rest of the library by setting
local stepindex Nat. The diff of this PR looks a lot larger than it really is: Few proofs actually changed so I hope this one will be relatively easy to review.Along the way, I partly addressed #730 (a few cases I noticed while re-reviewing OFE) and tidied a few proofs here and there.
Checklist
authorssection of any appropriate files.